From 5ef22c17596240a33690f5e049475da56b181fe8 Mon Sep 17 00:00:00 2001 From: innovaker <66737976+innovaker@users.noreply.github.com> Date: Sun, 9 May 2021 12:27:27 +0100 Subject: [PATCH] refactor: remove `push` from `cache-from` and `cache-to` `push` has no meaning in the context of `cache-from` or `cache-to`. PR: #20 --- .github/workflows/containers.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/containers.yml b/.github/workflows/containers.yml index 078e92a..aeb7ee2 100644 --- a/.github/workflows/containers.yml +++ b/.github/workflows/containers.yml @@ -23,10 +23,8 @@ jobs: include: - target: dev cache-to: dev - push-cache: true - target: build cache-to: build - push-cache: false steps: - name: Login to GitHub Container Registry uses: docker/login-action@v1 @@ -87,8 +85,8 @@ jobs: org.opencontainers.image.source=${{ github.server_url }}/${{ github.repository }} tags: | docker.io/${{ secrets.DOCKER_HUB_NAMESPACE }}/${{ steps.vars.outputs.candidate-tag }} - cache-from: type=registry,ref=docker.io/${{ secrets.DOCKER_HUB_NAMESPACE }}/${{ steps.vars.outputs.cache-from }},push=false - cache-to: type=registry,ref=docker.io/${{ secrets.DOCKER_HUB_NAMESPACE }}/${{ steps.vars.outputs.cache-to }},mode=max,push=${{ matrix.push-cache }} + cache-from: type=registry,ref=docker.io/${{ secrets.DOCKER_HUB_NAMESPACE }}/${{ steps.vars.outputs.cache-from }} + cache-to: type=registry,ref=docker.io/${{ secrets.DOCKER_HUB_NAMESPACE }}/${{ steps.vars.outputs.cache-to }},mode=max push: true - name: Image digest if: ${{ !startsWith(github.ref, 'refs/tags') }}