sporq/qmk-firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Core] Replace Tapping Force Hold feature with Quick Tap Term (#17007)

Browse Source 
* Replace Tapping Force Hold feature with Quick Tap Term

* Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0

* Deprecate force hold in info_config.json

* Before and after quick tap term unit tests

* Quick tap unit tests iteration

* Keymap config.h correction

* Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed

* Add two more test cases for quick tap

* Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2

* Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2

* Add function declaration for get_quick_tap_term

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
This commit is contained in:
Albert Y
2022-12-12 23:52:22 +08:00
committed by GitHub
parent 8698d109d7
commit cbabc8dbe6
226 changed files with 462 additions and 380 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
keyboards/ergodox_ez/keymaps/stamm/config.h
View File

@@ -32,8 +32,8 @@
#define IGNORE_MOD_TAP_INTERRUPT
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY
#define TAPPING_FORCE_HOLD
#define TAPPING_FORCE_HOLD_PER_KEY
#define QUICK_TAP_TERM 0
#define QUICK_TAP_TERM_PER_KEY
/* #define RETRO_TAPPING */
#undef LED_BRIGHTNESS_DEFAULT

37
keyboards/ergodox_ez/keymaps/stamm/keymap.c
View File

@@ -225,28 +225,25 @@ bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record) {
}
}
bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LT(_1_NUMBERS, KC_E):
case R_MOUSE:
case LSFT_T(KC_A):
case LCTL_T(KC_S):
case LALT_T(KC_D):
case LGUI_T(KC_F):
case RGUI_T(KC_J):
case RALT_T(KC_K):
case RCTL_T(KC_L):
case RSFT_T(KC_SEMICOLON):
case ARROWS:
return false;
default:
return true;
}
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case LT(_1_NUMBERS, KC_E):
case R_MOUSE:
case LSFT_T(KC_A):
case LCTL_T(KC_S):
case LALT_T(KC_D):
case LGUI_T(KC_F):
case RGUI_T(KC_J):
case RALT_T(KC_K):
case RCTL_T(KC_L):
case RSFT_T(KC_SEMICOLON):
case ARROWS:
return QUICK_TAP_TERM;
default:
return 0;
}
}
LEADER_EXTERNS();
void matrix_scan_user(void) {