sporq/qmk-firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Bug] Fix compiliation issue for Key Overrides (#19856)

Browse Source
This commit is contained in:
Drashna Jaelre 2023-02-15 13:06:10 -08:00 committed by GitHub
parent 7bd049a79a
commit a63808c23f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
quantum/process_keycode/process_key_override.c
View File

@ -186,7 +186,7 @@ const key_override_t *clear_active_override(const bool allow_reregister) {
// Then unregister the mod-free replacement key if desired // Then unregister the mod-free replacement key if desired
if (unregister_replacement) { if (unregister_replacement) {
if (IS_KEY(mod_free_replacement)) { if (IS_BASIC_KEYCODE(mod_free_replacement)) {
del_key(mod_free_replacement); del_key(mod_free_replacement);
} else { } else {
key_override_printf("NOT KEY 1\n"); key_override_printf("NOT KEY 1\n");
@ -329,7 +329,7 @@ static bool try_activating_override(const uint16_t keycode, const uint8_t layer,
if (!trigger_down && !no_trigger) { if (!trigger_down && !no_trigger) {
// When activating a key override the trigger is is always unregistered. In the case where the key that newly pressed is not the trigger key, we have to explicitly remove the trigger key from the keyboard report. If the trigger was just pressed down we simply suppress the event which also has the effect of the trigger key not being registered in the keyboard report. // When activating a key override the trigger is is always unregistered. In the case where the key that newly pressed is not the trigger key, we have to explicitly remove the trigger key from the keyboard report. If the trigger was just pressed down we simply suppress the event which also has the effect of the trigger key not being registered in the keyboard report.
if (IS_KEY(override->trigger)) { if (IS_BASIC_KEYCODE(override->trigger)) {
del_key(override->trigger); del_key(override->trigger);
} else { } else {
unregister_code(override->trigger); unregister_code(override->trigger);
@ -356,7 +356,7 @@ static bool try_activating_override(const uint16_t keycode, const uint8_t layer,
schedule_deferred_register(mod_free_replacement); schedule_deferred_register(mod_free_replacement);
send_keyboard_report(); send_keyboard_report();
} else { } else {
if (IS_KEY(mod_free_replacement)) { if (IS_BASIC_KEYCODE(mod_free_replacement)) {
add_key(mod_free_replacement); add_key(mod_free_replacement);
} else { } else {
key_override_printf("NOT KEY 2\n"); key_override_printf("NOT KEY 2\n");