sporq/qmk-firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pressing two keys with the same keycode but different modifiers (#2710)

Browse Source 
* Fix extra keyboard report during test_fixture teardown

* Add tests for pressing two keys with only different modifers

* Fix #1708

When two keys that use the same keycode, but different modifiers were
pressed at the same time, the second keypress wasn't registered. This is
fixed by forcing a key release when we detect a new press for the same
keycode.

* Fix the NKRO version of is_key_pressed

* Fix uninitalized loop variable

Co-authored-by: Jack Humbert <jack.humb@gmail.com>
This commit is contained in:
fredizzimo
2020-03-13 20:09:38 +02:00
committed by GitHub
parent f89439ae09
commit 9e8767917d
6 changed files with 158 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tmk_core/common/action.c
View File

@@ -754,6 +754,13 @@ void register_code(uint8_t code) {
*/
#endif
{
// Force a new key press if the key is already pressed
// without this, keys with the same keycode, but different
// modifiers will be reported incorrectly, see issue #1708
if (is_key_pressed(keyboard_report, code)) {
del_key(code);
send_keyboard_report();
}
add_key(code);
send_keyboard_report();
}