2017-07-01 21:25:06 +02:00
|
|
|
/* Copyright 2017 Fred Sundvik
|
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
2021-11-22 22:15:04 +01:00
|
|
|
#include "keyboard_report_util.hpp"
|
|
|
|
#include "keycode.h"
|
2017-07-02 20:46:35 +02:00
|
|
|
#include "test_common.hpp"
|
2017-07-01 21:25:06 +02:00
|
|
|
#include "action_tapping.h"
|
2021-11-22 22:15:04 +01:00
|
|
|
#include "test_keymap_key.hpp"
|
2017-07-01 21:25:06 +02:00
|
|
|
|
|
|
|
using testing::_;
|
|
|
|
using testing::InSequence;
|
|
|
|
|
|
|
|
class Tapping : public TestFixture {};
|
|
|
|
|
|
|
|
TEST_F(Tapping, TapA_SHFT_T_KeyReportsKey) {
|
|
|
|
TestDriver driver;
|
|
|
|
InSequence s;
|
2021-11-22 22:15:04 +01:00
|
|
|
auto key_shift_hold_p_tap = KeymapKey(0, 7, 0, SFT_T(KC_P));
|
|
|
|
|
|
|
|
set_keymap({key_shift_hold_p_tap});
|
2017-07-01 21:25:06 +02:00
|
|
|
|
|
|
|
// Tapping keys does nothing on press
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.press();
|
2017-07-01 21:25:06 +02:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(_)).Times(0);
|
|
|
|
run_one_scan_loop();
|
2021-11-22 22:15:04 +01:00
|
|
|
|
2017-07-01 21:25:06 +02:00
|
|
|
// First we get the key press
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.release();
|
2017-07-01 21:25:06 +02:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
|
2021-11-22 22:15:04 +01:00
|
|
|
|
2017-07-01 21:25:06 +02:00
|
|
|
// Then the release
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
|
|
|
|
run_one_scan_loop();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(Tapping, HoldA_SHFT_T_KeyReportsShift) {
|
|
|
|
TestDriver driver;
|
|
|
|
InSequence s;
|
2021-11-22 22:15:04 +01:00
|
|
|
auto mod_tap_hold_key = KeymapKey(0, 7, 0, SFT_T(KC_P));
|
|
|
|
|
|
|
|
set_keymap({mod_tap_hold_key});
|
|
|
|
|
|
|
|
mod_tap_hold_key.press();
|
2017-07-01 21:25:06 +02:00
|
|
|
|
|
|
|
// Tapping keys does nothing on press
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(_)).Times(0);
|
|
|
|
idle_for(TAPPING_TERM);
|
2021-11-22 22:15:04 +01:00
|
|
|
|
2021-11-04 06:22:17 +01:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LEFT_SHIFT)));
|
2017-07-01 21:25:06 +02:00
|
|
|
run_one_scan_loop();
|
2021-11-22 22:15:04 +01:00
|
|
|
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
|
|
|
|
mod_tap_hold_key.release();
|
|
|
|
run_one_scan_loop();
|
2017-07-01 21:25:06 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(Tapping, ANewTapWithinTappingTermIsBuggy) {
|
2017-07-08 18:48:22 +02:00
|
|
|
// See issue #1478 for more information
|
2017-07-01 21:25:06 +02:00
|
|
|
TestDriver driver;
|
|
|
|
InSequence s;
|
2021-11-22 22:15:04 +01:00
|
|
|
auto key_shift_hold_p_tap = KeymapKey(0, 7, 0, SFT_T(KC_P));
|
|
|
|
|
|
|
|
set_keymap({key_shift_hold_p_tap});
|
2017-07-01 21:25:06 +02:00
|
|
|
|
|
|
|
// Tapping keys does nothing on press
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.press();
|
2017-07-01 21:25:06 +02:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(_)).Times(0);
|
|
|
|
run_one_scan_loop();
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.release();
|
|
|
|
|
2017-07-01 21:25:06 +02:00
|
|
|
// First we get the key press
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
|
|
|
|
// Then the release
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
|
|
|
|
run_one_scan_loop();
|
|
|
|
|
|
|
|
// This sends KC_P, even if it should do nothing
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.press();
|
2017-07-01 21:25:06 +02:00
|
|
|
// This test should not succed if everything works correctly
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
|
|
|
|
run_one_scan_loop();
|
2021-11-22 22:15:04 +01:00
|
|
|
|
|
|
|
key_shift_hold_p_tap.release();
|
2017-07-01 21:25:06 +02:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
|
|
|
|
idle_for(TAPPING_TERM + 1);
|
|
|
|
|
|
|
|
// On the other hand, nothing is sent if we are outside the tapping term
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.press();
|
2017-07-01 21:25:06 +02:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(_)).Times(0);
|
|
|
|
run_one_scan_loop();
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.release();
|
2017-07-01 21:25:06 +02:00
|
|
|
|
|
|
|
// First we get the key press
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_P)));
|
|
|
|
// Then the release
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
|
|
|
|
idle_for(TAPPING_TERM + 1);
|
|
|
|
|
|
|
|
// Now we are geting into strange territory, as the hold registers too early here
|
|
|
|
// But the stranges part is:
|
|
|
|
// If TAPPING_TERM + 1 above is changed to TAPPING_TERM or TAPPING_TERM + 2 it doesn't
|
2021-11-22 22:15:04 +01:00
|
|
|
key_shift_hold_p_tap.press();
|
2017-07-01 21:25:06 +02:00
|
|
|
// Shouldn't be called here really
|
2021-11-04 06:22:17 +01:00
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LEFT_SHIFT))).Times(1);
|
2017-07-01 21:25:06 +02:00
|
|
|
idle_for(TAPPING_TERM);
|
2021-11-22 22:15:04 +01:00
|
|
|
|
|
|
|
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport()));
|
|
|
|
key_shift_hold_p_tap.release();
|
|
|
|
run_one_scan_loop();
|
|
|
|
}
|