sporq/kmk_firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

initialize event handler lists in Key objects only when needed to reduce memory footprint

Browse Source
This commit is contained in:
Christian Tu 2021-09-17 15:50:45 +02:00
parent 27cf8e7d4d
commit 3ad2a00dc9
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
kmk/keys.py
View File

@ -401,10 +401,6 @@ class Key:
self.no_press = bool(no_press) self.no_press = bool(no_press)
self.no_release = bool(no_press) self.no_release = bool(no_press)
self._pre_press_handlers = []
self._post_press_handlers = []
self._pre_release_handlers = []
self._post_release_handlers = []
self._handle_press = on_press self._handle_press = on_press
self._handle_release = on_release self._handle_release = on_release
self.meta = meta self.meta = meta
@ -424,24 +420,28 @@ class Key:
return 'Key(code={}, has_modifiers={})'.format(self.code, self.has_modifiers) return 'Key(code={}, has_modifiers={})'.format(self.code, self.has_modifiers)
def on_press(self, state, coord_int, coord_raw): def on_press(self, state, coord_int, coord_raw):
if hasattr(self, '_pre_press_handlers'):
for fn in self._pre_press_handlers: for fn in self._pre_press_handlers:
if not fn(self, state, KC, coord_int, coord_raw): if not fn(self, state, KC, coord_int, coord_raw):
return None return None
ret = self._handle_press(self, state, KC, coord_int, coord_raw) ret = self._handle_press(self, state, KC, coord_int, coord_raw)
if hasattr(self, '_post_press_handlers'):
for fn in self._post_press_handlers: for fn in self._post_press_handlers:
fn(self, state, KC, coord_int, coord_raw) fn(self, state, KC, coord_int, coord_raw)
return ret return ret
def on_release(self, state, coord_int, coord_raw): def on_release(self, state, coord_int, coord_raw):
if hasattr(self, '_pre_release_handlers'):
for fn in self._pre_release_handlers: for fn in self._pre_release_handlers:
if not fn(self, state, KC, coord_int, coord_raw): if not fn(self, state, KC, coord_int, coord_raw):
return None return None
ret = self._handle_release(self, state, KC, coord_int, coord_raw) ret = self._handle_release(self, state, KC, coord_int, coord_raw)
if hasattr(self, '_post_release_handlers'):
for fn in self._post_release_handlers: for fn in self._post_release_handlers:
fn(self, state, KC, coord_int, coord_raw) fn(self, state, KC, coord_int, coord_raw)
@ -485,6 +485,8 @@ class Key:
calls of this method will be executed before those provided by later calls. calls of this method will be executed before those provided by later calls.
''' '''
if not hasattr(self, '_pre_press_handlers'):
self._pre_press_handlers = []
self._pre_press_handlers.append(fn) self._pre_press_handlers.append(fn)
return self return self
@ -508,6 +510,8 @@ class Key:
calls of this method will be executed before those provided by later calls. calls of this method will be executed before those provided by later calls.
''' '''
if not hasattr(self, '_post_press_handlers'):
self._post_press_handlers = []
self._post_press_handlers.append(fn) self._post_press_handlers.append(fn)
return self return self
@ -532,6 +536,8 @@ class Key:
calls of this method will be executed before those provided by later calls. calls of this method will be executed before those provided by later calls.
''' '''
if not hasattr(self, '_pre_release_handlers'):
self._pre_release_handlers = []
self._pre_release_handlers.append(fn) self._pre_release_handlers.append(fn)
return self return self
@ -555,6 +561,8 @@ class Key:
calls of this method will be executed before those provided by later calls. calls of this method will be executed before those provided by later calls.
''' '''
if not hasattr(self, '_post_release_handlers'):
self._post_release_handlers = []
self._post_release_handlers.append(fn) self._post_release_handlers.append(fn)
return self return self