sporq/kmk_firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

updates based on review comments

Browse Source
This commit is contained in:
Syed Hussaini 2022-04-25 08:51:26 -05:00 committed by xs5871
parent bce7959f66
commit 1b902b907c
2 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
kmk/modules/modholdandtap.py
View File

@ -27,17 +27,15 @@ class ModHoldAndTap(Module):
def process_key(self, keyboard, key, is_pressed, int_coord): def process_key(self, keyboard, key, is_pressed, int_coord):
if isinstance(key.meta, ModHoldAndTapValidator): if isinstance(key.meta, ModHoldAndTapValidator):
layer_id = keyboard.active_layers[0] if self._active and self._prev_key is not None and is_pressed:
if layer_id > 0: # release previous key
if self._active and self._prev_key is not None and is_pressed: self.release(keyboard, self._prev_key)
# release previous key self._prev_key = key
self.release(keyboard, self._prev_key) if is_pressed:
self._prev_key = key keyboard.process_key(key.meta.mod, is_pressed)
if is_pressed:
keyboard.process_key(key.meta.mod, is_pressed)
self._active = True self._active = True
keyboard.process_key(key.meta.kc, is_pressed) keyboard.process_key(key.meta.kc, is_pressed)
elif self._active: elif self._active:
# release previous key if any other key is pressed # release previous key if any other key is pressed

6
tests/test_modholdandtap.py
View File

@ -46,6 +46,10 @@ class TestModHoldLayerTap(unittest.TestCase):
(1, False), (1, False),
], ],
[ [
{KC.LSFT, KC.LCTL, KC.TAB},
{KC.LSFT, KC.LCTL},
{KC.LSFT, KC.LCTL, KC.TAB},
{KC.LSFT, KC.LCTL},
{KC.B}, {KC.B},
{}, {},
], ],
@ -97,6 +101,8 @@ class TestModHoldLayerTap(unittest.TestCase):
{KC.LGUI}, {KC.LGUI},
{KC.B}, {KC.B},
{}, {},
{KC.LSFT, KC.LCTL, KC.TAB},
{KC.LSFT, KC.LCTL},
{KC.B}, {KC.B},
{}, {},
], ],